Skip to content

Add FloatingPanelDetent.Preference#1163

Closed
dfeinzimer wants to merge 7211 commits intov.nextfrom
df/FloatingPanelDetent.Preference
Closed

Add FloatingPanelDetent.Preference#1163
dfeinzimer wants to merge 7211 commits intov.nextfrom
df/FloatingPanelDetent.Preference

Conversation

@dfeinzimer
Copy link
Collaborator

@dfeinzimer dfeinzimer commented May 10, 2025 •
edited
Loading

In certain situations, a view presented in a floating panel needs the map view to be revealed for user interaction:

Typically, this would require the presented view to have a binding to the floating panel's detent; however, the view might not be presented in a floating panel. By providing this internal preference, Toolkit components can communicate a preferred detent to the Floating Panel without developers needing to write any code. Example usage.

yo1995 and others added 30 commits March 25, 2025 11:44
@yo1995
Fix phrasing for OfflineManager API doc.
ac835f1
@yo1995
Add doc:OfflineMapAreas.
720f781
@yo1995
Add version info for OfflineMapInfo.
e350ed0
@yo1995
Adjust behavior section and add code snippet for modifier usage.
5a1e859
@yo1995
Rephrase some words.
f3211da
@yo1995
webmap -> web map.
e7dfa0b
@yo1995
Add preview image header to the article. Image from #1112.
1217ae7
@yo1995
Adjust formatting based on suggestions.
4c5a051
@yo1995 @des12437
Apply suggestions from code review
e98ca37 
Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
@yo1995
Adjust formatting.
01e800c
@des12437
Fix typo
42142d7
@des12437
Update OfflineMapAreasViewTutorial.tutorial
0621dd1
@yo1995
Adjust phrasing.
12b1ca2
@dfeinzimer
Modify focus handling
e5e641f
@des12437
Reorder tutorial steps
dfe3cfc
@des12437 @yo1995
Update Sources/ArcGISToolkit/Documentation.docc/Tutorials/OfflineMapA…
3c5b9f7 
…reasViewTutorial.tutorial

Co-authored-by: Ting <tchen@esri.com>
@des12437
Remove MainActor annotation
0eee73d
@dfeinzimer
Initialize a SwiftUI Image directly
5d62809 
No force unwrapping needed
@dfeinzimer
Make UIImage.mapPin optional
7e54d3a 
Between 200.7.0-4889 and 4990 this resource became unavailable in swift-toolkit-daily
@dfeinzimer
Fallback to SimpleMarkerSymbol when mapPin unavailable
79ab953
@dfeinzimer
Take some public types internal
9aeb285
@jona7150
Update translation - @mit10976 @Isa13169 @nia13404
6a2e5b9
@dfeinzimer
Merge pull request #1115 from Esri/translation-l10n-staging
d07d985 
feat(localization): update translation
@dfeinzimer
Merge pull request #1117 from Esri/l10n-staging
aba89bb 
Update translations for 200.7
@des12437
Merge pull request #1112 from Esri/destiny/offline-tutorial
6300de0 
Offline: Tutorial
@yo1995
Merge branch 'v.next' into Ting/OfflineAPIDoc
7c5a1bb
@yo1995
Add entry to README.
4aa0610
@yo1995
Address review suggestion.
388a0cf 
See #1111 (comment)
@yo1995
A/an.
44bc383 
See #1111 (comment)
@yo1995
Button hidden description.
e3bcf86 
See #1111 (comment)
dfeinzimer and others added 16 commits May 2, 2025 17:28
@dfeinzimer
Create NavigationLayer+View
bb29687
@dfeinzimer
Reorganize NavigationLayer.swift
2e6393e
@dfeinzimer
FeatureFormView - Fix testCase_11_1 for visionOS
0f09fc6
@dfeinzimer
Merge pull request #1159 from Esri/dfeinzimer-patch-2
7857734 
`FeatureFormView` - Fix testCase_11_1 for visionOS
@dfeinzimer
Repair testCase_1
90da334
@dfeinzimer @CalebRas
Update Sources/ArcGISToolkit/Common/NavigationLayer/NavigationLayer+H…
a99189b 
…eader.swift

Co-authored-by: Caleb Rasmussen <crasmussen@esri.com>
@dfeinzimer @CalebRas
Update Sources/ArcGISToolkit/Common/NavigationLayer/NavigationLayer.s…
8209fd0 
…wift

Co-authored-by: Caleb Rasmussen <crasmussen@esri.com>
@dfeinzimer @CalebRas
Update Sources/ArcGISToolkit/Common/NavigationLayer/NavigationLayer.s…
76cc4e7 
…wift

Co-authored-by: Caleb Rasmussen <crasmussen@esri.com>
@dfeinzimer @CalebRas
Update Sources/ArcGISToolkit/Common/NavigationLayer/NavigationLayer.s…
8d5912e 
…wift

Co-authored-by: Caleb Rasmussen <crasmussen@esri.com>
@dfeinzimer @CalebRas
Update Sources/ArcGISToolkit/Common/NavigationLayer/NavigationLayer.s…
8de872c 
…wift

Co-authored-by: Caleb Rasmussen <crasmussen@esri.com>
@dfeinzimer @CalebRas
Update Sources/ArcGISToolkit/Extensions/SwiftUI/AnyTransition.swift
e14ca6a 
Co-authored-by: Caleb Rasmussen <crasmussen@esri.com>
@dfeinzimer @CalebRas
Update Sources/ArcGISToolkit/Common/NavigationLayer/NavigationLayerMo…
cd490ea 
…del.swift

Co-authored-by: Caleb Rasmussen <crasmussen@esri.com>
@dfeinzimer
Fix Xcode 16.2 build error
f0cbd9f
@dfeinzimer
Merge pull request #1157 from Esri/df/NavigationLayer
b57f1e2 
Add `NavigationLayer`
@dfeinzimer
Add FloatingPanelDetent.Preference
fd27836
@dfeinzimer
Doc
5767507
@dfeinzimer dfeinzimer requested a review from mhdostal May 10, 2025 00:26
@dfeinzimer dfeinzimer self-assigned this May 10, 2025
@dfeinzimer dfeinzimer added the enhancement New feature or request label May 10, 2025
mhdostal
mhdostal previously approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@mhdostal mhdostal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good and is a nice way to override the detentions when a component needs to.

@dfeinzimer
Copy link
Collaborator Author

dfeinzimer commented May 12, 2025

A reservation I have with this approach is that supporting the same behavior for sheets seems problematic. Sheets (surprisingly) don't animate nicely when nested views with the presentationDetents(_:) modifier applied appear and disappear:

Should we forego this magic approach and instead have developers manage their detents by adding more cases to FeatureFormView.EditingEvent like mapInteractionStarted/mapInteractionEnded?

@mhdostal
Copy link
Member

mhdostal commented May 13, 2025

Should we forego this magic approach and instead have developers manage their detents by adding more cases to FeatureFormView.EditingEvent like mapInteractionStarted/mapInteractionEnded?

Will this alleviate the problems with sheets?

@dfeinzimer
Copy link
Collaborator Author

dfeinzimer commented May 20, 2025

Will this alleviate the problems with sheets?

It doesn't seem to. There's some discussion about this issue here, but I haven't yet been able to make the suggestions work correctly with our views.

Regardless, it might be best overall to take the sheet/panel agnostic approach and just report what the user is doing via the new cases suggested above on FeatureFormView.EditingEvent or another new enum altogether.

@mhdostal
Copy link
Member

mhdostal commented May 20, 2025

Regardless, it might be best overall to take the sheet/panel agnostic approach and just report what the user is doing via the new cases suggested above on FeatureFormView.EditingEvent or another new enum altogether.

Ok. Let's try and make it the default/predominant use case work with little or not extra code.

@dfeinzimer dfeinzimer marked this pull request as draft May 22, 2025 18:02
@mhdostal mhdostal closed this May 22, 2025
@mhdostal mhdostal force-pushed the df/FloatingPanelDetent.Preference branch from 1934874 to d2b5cf8 Compare May 22, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhdostal mhdostal mhdostal left review comments

Assignees

@dfeinzimer dfeinzimer

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dfeinzimer @mhdostal @yo1995 @des12437 @jona7150 @rolson @philium